[jira] [Commented] (AXIS2-5068) Enable engaging addressing module to service level.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (AXIS2-5068) Enable engaging addressing module to service level.

Adam Fordham (Jira)

    [ https://issues.apache.org/jira/browse/AXIS2-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015216#comment-17015216 ]

Jeff Thomas commented on AXIS2-5068:
------------------------------------

This problem is ancient (2011) but still exists in the current trunk version so I thought I would add my two cents here.

OOTB Axis2 maps the 'engagedModules' keyed by archive name and not module name... this means 'isEngaged("addressing")' will not work - you need to lookup 'isEngaged("addressing-1.7.4")' (the archive file name is pulled from the MAR file).

This makes no sense because (1) at runtime you don't care about the version, you only want to reference the module by name and (2) if you do reference a specific-version as soon as you upgrade Axis2 or your own custom modules to a new version your code will break.

See my comments on https://issues.apache.org/jira/browse/AXIS2-5721 for my *potential* workaround - plus some other module trickiness you might want to be aware of. :O 

> Enable engaging addressing module to service level.
> ---------------------------------------------------
>
>                 Key: AXIS2-5068
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5068
>             Project: Axis2
>          Issue Type: Bug
>          Components: Addressing
>    Affects Versions: 1.5.4
>         Environment: Windows
>            Reporter: shivendra tripathi
>            Priority: Major
>
> Currently addressing module could only engage at global level. To enable it at service level we need to to do following check in addressing handler invoke method
> if  (!msgContext.isEngaged("Addressing")) {
>     return InvocationResponse.CONTINUE;
>       }
> If above make sense then I can provide patch for all the addressing handler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]